Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Formator and Basic brainyquotes test added #26

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Code Formator and Basic brainyquotes test added #26

wants to merge 13 commits into from

Conversation

sayanmondal2098
Copy link

No description provided.

Copy link
Member

@sunn-e sunn-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. This is a good approach, we may not see ambiguous behavior on ' symbols commonly used in quotes. @akshatkarani Have a look.

@sunn-e
Copy link
Member

sunn-e commented Jul 5, 2019

Hey @sayanmondal2098 Good job, Let me know when you are finished and I will merge your PR.

Copy link
Contributor

@akshatkarani akshatkarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I have updated the directory structure, can you update accordingly.

pyquotes/brainyquote.py Outdated Show resolved Hide resolved
pyquotes/brainyquote.py Outdated Show resolved Hide resolved
pyquotes/brainyquote.py Outdated Show resolved Hide resolved
@sunn-e sunn-e added the Hacktoberfest go to https://hacktoberfest.digitalocean.com/ for more details label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest go to https://hacktoberfest.digitalocean.com/ for more details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants